Add ES Module Build to Support Modern Project Setups #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may have noticed that your change in the rollup config doesn't change any of the distributed files - that's because CountUp.js has been distributed as an ES6 module for about the last 4 years. I think the change that is causing issues over on react countup is that in package.json I set "main" to point at the ES6 module. Previously it was pointed at the UMD module. So the problem is not the module format. react-countup should update how they import countUp or pin at 2.6.0. |
|
In the meantime I would suggest using CountUp directly in react instead of the react-countup lib: https://gist.github.com/inorganik/2cf776865a4c65c12857027870e9898e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ES Module Build to Support Modern Project Setups to fix issue #312
Checklist
Description
This pull request introduces an additional build output in ES module format for the
countUp.jslibrary. The purpose of this change is to provide better compatibility with modern project setups that use bundlers like Webpack, which are optimized for handling ES module syntax.Previously, the library was built only in UMD format, which may have caused issues in some project setups, such as encountering "Unexpected token 'export'" errors. This update addresses this problem by adding a new build target with ES module output, allowing users to seamlessly integrate countUp.js into their projects with ES module support.
Here are the key changes made in this pull request:
By providing an ES module build alongside the existing UMD build, this update ensures that the library caters to a wider range of project configurations, thus enhancing its compatibility and ease of use for developers.
Does this PR introduce a breaking change?