feat: add a callback method on start #321
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, thank you for the PR. Looking at this though I am not inclined to merge, because I can't see a reason for the change. The onComplete callback exists because it will automatically execute when the animation ends, but if you want to call something when the animation starts, you can simply call it in the next line after start(). |
|
Hi, when enableScrollSpy is turned on, the start() method is not called manually, so this hook is added. |
|
Thanks, that makes sense. Published in v2.8.0! |
inorganik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a...
Checklist
Description
add a fallback method on start
Does this PR introduce a breaking change?