Get Countup Number From Target Element #343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is my first PR for a Typescript project. Just learned the basics to Typescript and I hope these changes can be made. I did run the tests and none of the tests fail. And the PR has very few lines of code changes. |
inorganik
reviewed
May 23, 2025
src/countUp.ts
Outdated
| @@ -335,4 +337,7 @@ export class CountUp { | |||
| easeOutExpo = (t: number, b: number, c: number, d: number): number => | |||
| c * (-Math.pow(2, -10 * t / d) + 1) * 1024 / 1023 + b; | |||
|
|
|||
| removeSeparators(number: string): number { | |||
| return Number(number.split(',').join('')); | |||
There was a problem hiding this comment.
Can you change this to the following:
return parseFloat(str.replace(new RegExp(this.options.separator, 'g'), ''))
Using parseFloat()
|
Done You may want to add a test for it, this is my demo/test code for the feature to ensure it works...
<script>
window.addEventListener("load", function () {
new countUp.CountUp("my-count-up").start();
});
</script>">
|
|
Thank you for accepting the pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a...
Checklist
Description
please describe the changes that you are making
Adding this feature request
#301
for features, please describe how to use the new feature
This feature allows you not to have to set the
endValparameter when constructing theCountUp()object. This will allow it to default to reading the target element inner HTML as theendVal.The target element innerHTML can be a generic number such as
2000or it can have separators2,000and a new internal method will parse the innerHTML value to remove the separators and convert it to a number.please include a reference to an existing issue, if applicable
#301
Does this PR introduce a breaking change?