Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm submitting a...
Checklist
Description
Thank you for accepting the recent pull request on making the
endValargument optional by having the method look at the element inner HTML for a value if null or undefined is given as theendValvalue. That pull request should cause minor breakage.This pull request is to modify the
CountUp()method by removing theendValargument and movingendValas one of the options in theoptionsargument.This will allow for the following code to work...
No need to for code like this...
Since
endValis now optional, it should be an option, not a required argument for when you want to set some options.I also updated the tests, the README.md and demo scripts to include these changes to make this pull request as seamless as possible.
All of the updated tests do pass.
This however will cause breaking changes and I would suggest pushing this for a 3.0.0 release.
Does this PR introduce a breaking change?